Skip to content

Conversation

ByMykel
Copy link
Contributor

@ByMykel ByMykel commented Jan 23, 2023

I've translated all the facts in English to Spanish from Spain. One word I can't translate correctly is 'clowder'.

closes #210

@ByMykel
Copy link
Contributor Author

ByMykel commented Jan 23, 2023

I'm targeting main as I saw previous PR with translations did the same.

@BeauBouchard
Copy link
Member

Thank you for the great contribution! :D

@ByMykel
Copy link
Contributor Author

ByMykel commented Feb 21, 2023

@BeauBouchard It seems that a test failed because I've changed the first fact. Can I fix it in this PR?

@BeauBouchard
Copy link
Member

@BeauBouchard It seems that a test failed because I've changed the first fact. Can I fix it in this PR?

yes, i can also fix it as well, simply its a type-O from an old test before this commit

 + expected - actual

      -En 1987 los gatos superaron a los perros como la mascota número uno en Estados Unidos.
     +En 1987, los gatos superaron a los perros como la mascota número uno en Estados Unidos.

@BeauBouchard
Copy link
Member

Perfect, looks like it was just that one missing character, thanks again for the quality contribution and sorry we didn't get it in immediately.

@BeauBouchard BeauBouchard merged commit f9b4df4 into wh-iterabb-it:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[i18n] Español ES
2 participants