Render helper render_template, ensure_dir function bug #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I REALLY appreciated the documentation :) Thanks. I dropped you my very last request: since the return of Once done, I'm ready to merge this one w/o any further review thus w/o any further waiting :) Thanks for your work. |
| @@ -246,21 +248,30 @@ function wl_yield() { | |||
| render_template($current_view, $current_locals); | |||
| } | |||
|
|
|||
| private function ensure_dir($dir) { | |||
| private function ensure_tmp_dir() { | |||
There was a problem hiding this comment.
Suggested change
| private function ensure_tmp_dir() { | |
| private function ensure_tmp_dir(): bool { |
| return apply_filters('wordless_tmp_dir_exists', $tmpDir, $tmp_dir_exists_and_writable ); | ||
| } | ||
|
|
||
| private function ensure_dir( $dir ) { |
There was a problem hiding this comment.
Suggested change
| private function ensure_dir( $dir ) { | |
| private function ensure_dir( string $dir ): bool { |
alessandro-fazzi
added a commit
that referenced
this pull request
Apr 14, 2023
Fix #284 Previously proposed by @arun744-newscorp, but never brought to the end. I've just added the needed type declarations to the brought-back original #283 :)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In render_helper.php file in function error was identified: Ouch!! It seems that the /var/www/wp-content/themes/<>/tmp
ensure_dir function sometimes cannot override the tmp folder permission to writeable, some server forbid the chmod action. Hence we compile our files via CLI during CI build process, this generates files in tmp DIR. Now I have corrected version of ensure_dir function test in our environment to check both compiled files in tmp and also create tmp if didn't exist this applies for both scenario.
Secondly we have filter 'wordless_environment' to override the environment.