-
Notifications
You must be signed in to change notification settings - Fork 104
Release version #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release version #253
Conversation
标准化工作流文件中的数组格式,将元素间的空格统一。同时将 VERSION 变量从 env.GITHUB_REF_NAME 改为直接使用 github.ref_name,保持与其他 git 相关变量的一致性
📝 WalkthroughSummary by CodeRabbit
Walkthrough本次更新主要涉及 GitHub Actions 工作流文件的格式优化与变量引用调整,以及前端组件 Changes
Poem
✨ Finishing Touches
🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
.github/workflows/build-docker-image.yml (1)
124-139
: 仍在使用未定义的env.GITHUB_REF_NAME
,可能导致镜像标签缺失虽然本次改动已将
VERSION
构建参数切换为${{ github.ref_name }}
,但 126~133 行的多个tags:
仍引用${{ env.GITHUB_REF_NAME }}
。该变量在env:
块并未定义,运行时会展开为空字符串,进而生成非法的镜像标签(如:latest
后出现双冒号或空标签)。请统一改为 GitHub 上下文变量,或在
env:
中补充定义:- ${{ env.DOCKERHUB_USERNAME }}/${{ env.IMAGE_REPONAME }}:${{ env.GITHUB_REF_NAME }} + ${{ env.DOCKERHUB_USERNAME }}/${{ env.IMAGE_REPONAME }}:${{ github.ref_name }}其余同理,确保所有引用一致。
🧹 Nitpick comments (2)
.github/workflows/build-docker-image.yml (1)
38-38
: 矩阵写法保持一致即可同上,仅为视觉统一;若后续需要多版本构建,可直接扩展该数组。
ui/src/components/Amis/custom/cluster/ClusterSummaryView.tsx (1)
277-290
:Avatar
行内样式与size
属性重复
size={48}
已会设置宽高;同时再在style
中指定width/height: 48
属于冗余,可简化:- width: 48, - height: 48,无功能问题,仅减小样式噪音。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/build-docker-image.yml
(3 hunks).github/workflows/build-release.yml
(3 hunks)ui/src/components/Amis/custom/cluster/ClusterSummaryView.tsx
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (go)
🔇 Additional comments (4)
.github/workflows/build-docker-image.yml (1)
11-12
: 格式微调 OK,可保持一致性数组两侧加空格仅影响可读性,无功能差异,与其他工作流保持统一即可。
.github/workflows/build-release.yml (2)
55-55
:VERSION
参数已正确切换至github.ref_name
该修改解决了 Release 触发场景下获取不到版本号的问题,👍。
5-6
: 格式化改动无功能影响保持与其他工作流一致即可。
Also applies to: 14-14
ui/src/components/Amis/custom/cluster/ClusterSummaryView.tsx (1)
297-307
: 长文本处理 👍新增
wordBreak
、maxWidth
等样式有效避免资源名过长撑破布局,改动合理。
No description provided.