This repository was archived by the owner on Aug 29, 2023. It is now read-only.
Use the knownhosts package from fluxcd/toolkit #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twelho
approved these changes
Jun 10, 2020
pkg/gitdir/gitdir.go
Outdated
| @@ -94,13 +99,19 @@ func NewGitDirectory(url string, opts GitDirectoryOptions) (*GitDirectory, error | |||
| switch ep.Protocol { | |||
| case "ssh": | |||
| // If we haven't got the right credentials, just continue in read-only mode | |||
| if len(opts.IdentityFileContent) == 0 { | |||
| if len(opts.IdentityFileContent) == 0 && len(opts.KnownHostsFileContent) == 0 { | |||
There was a problem hiding this comment.
This probably should be an OR-case? You need both the identity file and known hosts.
There was a problem hiding this comment.
Thanks for the catch, will fix!
|
I think we should drop the vendor dir, go modules have matured and you can easily cache them in CI e.g. https://github.com/fluxcd/toolkit/blob/master/.github/workflows/e2e.yaml#L16-L21 |
Thanks, will/can do, in a future PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
knownhostspackage here too so we can easily validate remotes.Thank you for making this work totally in-memory 😄!
Upgraded to Go 1.14, as fluxcd/toolkit depends on k8s v1.18 which requires newer than 1.12
/cc @stefanprodan @hiddeco
/assign @twelho