Skip to content
This repository was archived by the owner on Aug 29, 2023. It is now read-only.
This repository was archived by the owner on Aug 29, 2023. It is now read-only.

Review Flux code duplication #4

@dholbach

Description

@dholbach

@stefanprodan pointed out that some code of Flux made its way into gitops-toolkit. Could this be made a dependency instead?

[daniel@reef ~ ]$ ls ~/dev/{flux,gitops-toolkit/pkg}/git 
/home/daniel/dev/flux/git:
errors.go  export.go  export_test.go  gittest  mirrors.go  operations.go  operations_test.go  repo.go  signature.go  url.go  url_test.go  working.go

/home/daniel/dev/gitops-toolkit/pkg/git:
errors  errors.go  export.go  gitdir  mirrors.go  operations.go  repo.go  signature.go  url.go  working.go
[daniel@reef ~ ]$ diff -ruN ~/dev/{flux,gitops-toolkit/pkg}/git | diffstat
 errors.go            |   23 +-
 errors/errors.go     |   95 +++++++++++
 export.go            |   12 -
 export_test.go       |   44 -----
 gitdir/gitdir.go     |  234 ++++++++++++++++++++++++++++
 gittest/repo.go      |  122 --------------
 gittest/repo_test.go |  270 --------------------------------
 operations.go        |   46 ++---
 operations_test.go   |  424 ---------------------------------------------------
 repo.go              |   51 +-----
 url.go               |    2 
 url_test.go          |   20 --
 working.go           |   94 +++++++----
 13 files changed, 434 insertions(+), 1003 deletions(-)
[daniel@reef ~ ]$ 

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions