This repository was archived by the owner on Dec 7, 2023. It is now read-only.
Always set keep_bootcon on ARM64, and update default kernel params #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stealthybox
reviewed
Jan 29, 2020
| // Refer to https://github.com/firecracker-microvm/firecracker/blob/master/src/vmm/src/vmm_config/boot_source.rs | ||
| // TODO: The Firecracker team don't use console=ttyS0 anymore, but 8250.nr_uarts=0 instead | ||
| // See https://github.com/firecracker-microvm/firecracker/pull/313 for more info | ||
| VM_DEFAULT_KERNEL_ARGS = "console=ttyS0 reboot=k panic=1 pci=off ip=dhcp i8042.noaux i8042.nomux i8042.nopnp i8042.dumbkbd" |
There was a problem hiding this comment.
Do you know how involved this console related TODO is?
Looks like this patch is mostly enabling the i8042 keyboard.
stealthybox
reviewed
Jan 29, 2020
| // On ARM64, keep_bootcon needs to be applied to the kernel arguments | ||
| if runtime.GOARCH == "arm64" && !strings.Contains(cmdLine, "keep_bootcon") { | ||
| // Prepend keep_bootcon as per https://github.com/firecracker-microvm/firecracker/blob/master/docs/getting-started.md | ||
| cmdLine = fmt.Sprintf("keep_bootcon %s", cmdLine) |
There was a problem hiding this comment.
Why would we only enable this arg for ARM VM's ?
It looks to be mainly related to debugging boot:
https://lore.kernel.org/patchwork/patch/232096/
Did you find your aarch64 kernels did not boot without this option?
This seems like a strange thing to enable just because it's mentioned once in getting-started conditional with no comment.
|
Closing this as the Firecracker team said |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure
keep_bootconis given to the kernel args on ARM64.It also updates the default kernel params to the new recommendations.
cc @chanwit @stealthybox