Skip to content
This repository was archived by the owner on Dec 7, 2023. It is now read-only.
This repository was archived by the owner on Dec 7, 2023. It is now read-only.

Declarative port mappings and copy files values are getting cleared while CLI flags are empty #795

@onatm

Description

@onatm

The title is self-explanatory but I should give more details.

I start an ignite VM using the below declarative configuration by executing ignite run --config ubuntu.yaml:

apiVersion: ignite.weave.works/v1alpha3
kind: VM
metadata:
  name: ubuntu
spec:
  image:
    oci: weaveworks/ignite-ubuntu
  cpus: 1
  diskSize: 400MB
  memory: 64MB
  network:
    ports:
    - hostPort: 2222
      vmPort: 22
  ssh: true

When I run ignite ps I don't see any port mappings on the VM.

I've done some debugging and found where the issue is and it also showed me that copyFiles suffers the same problem.

Here's the offending line:

baseVM.Spec.Network.Ports, err = meta.ParsePortMappings(cf.PortMappings)

I'll be creating a PR to fix this issue

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugCategorizes issue or PR as related to a bug.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions