Skip to content
This repository was archived by the owner on Dec 7, 2023. It is now read-only.
This repository was archived by the owner on Dec 7, 2023. It is now read-only.

Cleanup error handling for SSH dial #472

@stealthybox

Description

@stealthybox

#469 introduced some quick error handling for the ssh.Dial result.

These conditionals work fine since this should almost always return an expected error, but some of the branches are incorrect.

The final return case is actually a success of the SSH connection. (This is unexpected, and should probably warn the user that an insecure password succeeded)

There may be a better way to auth this connection.
For instance, we could actually use the proper certs since we're going so far as to validate that the server is operating at a protocol level.

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomershacktoberfesthelp wantedExtra attention is neededkind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions