Skip to content

0.38.0 #1936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2020
Merged

0.38.0 #1936

merged 2 commits into from
Apr 8, 2020

Conversation

su-chang
Copy link
Member

@su-chang su-chang commented Apr 8, 2020

I'm submitting a...

[ ] Bug Fix
[ ] Feature
[x] Other (Refactoring, Added tests, Documentation, ...)

Checklist

  • Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
  • Tests for the changes have been added

Description

please describe the changes that you are making

for features, please describe how to use the new feature

please include a reference to an existing issue, if applicable

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

huan
huan requested changes Apr 8, 2020
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the wechaty-puppet to an even minor version before bump Wechaty because we are use devops to publish the npm module with CI/CD.

@su-chang
Copy link
Member Author

su-chang commented Apr 8, 2020

I have bump wechaty-puppet to even version. Maybe we should merge it first, and then after it published, this CI test will pass.

huan
huan approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing a new release for Wechaty!

@huan
Copy link
Member

huan commented Apr 8, 2020

Please create an new version release notes by filing an new issue, brief descript the reason, and link those two PRs together.

Thank you very much.

@huan huan merged commit 659ed6a into wechaty:master Apr 8, 2020
@su-chang su-chang mentioned this pull request Apr 8, 2020
Closed
@su-chang su-chang deleted the bump-version branch April 8, 2020 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huan huan huan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@su-chang @huan