Skip to content

Support message.toImage() method. #1913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Feb 18, 2020
Merged

Support message.toImage() method. #1913

merged 18 commits into from
Feb 18, 2020

Conversation

su-chang
Copy link
Member

I'm submitting a...

[ ] Bug Fix
[x] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)

Checklist

  • Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
  • Tests for the changes have been added

Description

please describe the changes that you are making

for features, please describe how to use the new feature

please include a reference to an existing issue, if applicable

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

su-chang and others added 16 commits October 31, 2019 14:05
@su-chang
0.29.3
22df662
@su-chang
modify: resolve conflict
888bfe5
@su-chang
Merge branch 'Chatie-master'
4a717c7
@su-chang
Merge pull request #5 from Chatie/master
58fc1e1 
feat: change say() method response type from void to Message (wechaty#1866)
@su-chang
Merge pull request #6 from wechaty/master
0935615 
Merge wechaty/wechaty
@su-chang
Merge pull request #7 from wechaty/master
92a67a2 
Merge wechaty/wechaty
@su-chang
Merge pull request #8 from wechaty/master
b8bfb93 
Merge wechaty master
@su-chang
Merge pull request #9 from wechaty/master
05a5b74 
Add reason for logout event (wechaty#1900)
@su-chang
Merge pull request #10 from wechaty/master
afe90a3 
Merge label and new friend search related methods
@su-chang
Merge pull request #11 from wechaty/master
4677b3e 
Merge master
@su-chang
Merge pull request #12 from wechaty/master
9aac563 
Merge master
@su-chang
Merge pull request #13 from wechaty/master
881e824 
Merge master
@su-chang
feat: support message.toImage() method
4a2a0ae
@su-chang
Merge pull request #14 from wechaty/master
a4b4a13 
Merge master
@su-chang
Merge branch 'master' into image
0e5862a
@su-chang
0.31.10
b6fb45d
@su-chang
Copy link
Member Author

Related issue: #1871

huan
huan reviewed Feb 18, 2020
View reviewed changes
src/user/image.ts Outdated
@@ -0,0 +1,64 @@
import { instanceToClass } from "clone-class"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run npm run lint:es before you send Pull Request, because we need to follow the original code styles.

huan
huan reviewed Feb 18, 2020
View reviewed changes
src/user/message.ts Outdated
@@ -966,6 +967,14 @@ export class Message extends Accessory implements Sayable {
return fileBox
}

public async toImage (): Promise<Image> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When adding a new API, please also add the related JS Docs.

huan
huan approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@huan huan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-designed the Image class, please feel free to let me know if you have any questions.

@huan huan merged commit 297dc4f into wechaty:master Feb 18, 2020
@su-chang
Copy link
Member Author

Thanks for your re-design.

Only one question about it:
The method url("") has been removed from Image class, we do not need it any more?

@huan
Copy link
Member

huan commented Feb 18, 2020

Please see my reply from the issue.

We can archive that because we are now using FileBox to store the image information.

@su-chang
Copy link
Member Author

OK, everything well. I will make some changes for wechaty-puppet-padplus now.

@huan huan mentioned this pull request Apr 20, 2020
Closed
@su-chang su-chang deleted the image branch June 30, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huan huan huan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@su-chang @huan