Skip to content

Support delay to accept room invitation #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Feb 11, 2020
Merged

Support delay to accept room invitation #1910

merged 17 commits into from
Feb 11, 2020

Conversation

su-chang
Copy link
Member

I'm submitting a...

[ ] Bug Fix
[ ] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)

Checklist

  • Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
  • Tests for the changes have been added

Description

please describe the changes that you are making

for features, please describe how to use the new feature

please include a reference to an existing issue, if applicable

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

su-chang and others added 14 commits October 31, 2019 14:05
@su-chang
0.29.3
22df662
@su-chang
modify: resolve conflict
888bfe5
@su-chang
Merge branch 'Chatie-master'
4a717c7
@su-chang
Merge pull request #5 from Chatie/master
58fc1e1 
feat: change say() method response type from void to Message (wechaty#1866)
@su-chang
Merge pull request #6 from wechaty/master
0935615 
Merge wechaty/wechaty
@su-chang
Merge pull request #7 from wechaty/master
92a67a2 
Merge wechaty/wechaty
@su-chang
Merge pull request #8 from wechaty/master
b8bfb93 
Merge wechaty master
@su-chang
Merge pull request #9 from wechaty/master
05a5b74 
Add reason for logout event (wechaty#1900)
@su-chang
Merge pull request #10 from wechaty/master
afe90a3 
Merge label and new friend search related methods
@su-chang
Merge pull request #11 from wechaty/master
4677b3e 
Merge master
@su-chang
Merge pull request #12 from wechaty/master
9aac563 
Merge master
@su-chang
feat: support delay accept room invitation
7ce0c45
@su-chang
0.31.4
52cf1ba
@su-chang
modify: bump wechaty-puppet version up
2da6203
@su-chang su-chang changed the title Room invitation Support delay to accept room invitation Feb 10, 2020
@su-chang
Copy link
Member Author

Related issue: #1823

huan
huan requested changes Feb 11, 2020
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should follow the same design pattern as the Friendship method before.

See: #1891

huan
huan approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following the design pattern that we already have.

Will merge it first and fix other issues like the puppet version mismatch.

@huan huan merged commit fb47be4 into wechaty:master Feb 11, 2020
@huan
Copy link
Member

huan commented Feb 11, 2020

This new feature will be available on Wechaty@v0.31.5 or above.

@huan huan mentioned this pull request Apr 20, 2020
Closed
@su-chang su-chang deleted the room-invitation branch June 30, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huan huan huan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@su-chang @huan