Add reason for logout event #1900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: change say() method response type from void to Message (wechaty#1866)
Merge wechaty/wechaty
Merge wechaty/wechaty
Merge wechaty master
|
Related issue: wechaty/wechaty-puppet-padplus#100 |
windmemory
requested changes
Jan 6, 2020
|
I think optional is flexible, if puppet which do not support the logout reason, it could ignore the parameter |
|
If no reason, an empty string could also work. But optional also works. I will not insist on this point. But I would insist on the separation of |
|
Got it. |
windmemory
previously approved these changes
Jan 7, 2020
|
@windmemory We should not approve any PR that did not pass the CI. If the CI is not green, we should never approve it unless we have to. Thanks! |
|
@huan ping |
huan
approved these changes
Jan 8, 2020
|
Thanks for making the CI green for this PR. |
su-chang
added a commit
to su-chang/wechaty
that referenced
this pull request
Jan 8, 2020
Add reason for logout event (wechaty#1900)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a...
Checklist
Description
please describe the changes that you are making
for features, please describe how to use the new feature
please include a reference to an existing issue, if applicable
Does this PR introduce a breaking change?