Skip to content

Update README.md #1876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 24, 2019
Merged

Update README.md #1876

merged 4 commits into from
Nov 24, 2019

Conversation

lijiarui
Copy link
Member

@lijiarui lijiarui commented Nov 21, 2019 •
edited
Loading

I'm submitting documentation, making it clear for users to apply free token.

Checklist

  • Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
  • Tests for the changes have been added

Does this PR introduce a breaking change?

No

huan
huan reviewed Nov 22, 2019
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please make the check green
  2. Please remove the deprecated puppets in the list, or add a DEPRECATED besides it.

huan
huan requested changes Nov 22, 2019
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fix

@huan huan merged commit e763024 into master Nov 24, 2019
@huan huan deleted the add-puppet-instruction branch November 24, 2019 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huan huan huan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lijiarui @huan