Skip to content

Update room-invite signature documentation #1784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update room-invite signature documentation #1784

wants to merge 1 commit into from

Conversation

xinbenlv
Copy link
Contributor

I'm submitting a...

[ ] Bug Fix
[ ] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)

Checklist

  • Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
  • Tests for the changes have been added

Description

please describe the changes that you are making

for features, please describe how to use the new feature

please include a reference to an existing issue, if applicable

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

@xinbenlv xinbenlv requested a review from lijiarui as a code owner May 22, 2019 16:11
@xinbenlv
Copy link
Contributor Author

Shippable failure is unrelated.

@xinbenlv
Copy link
Contributor Author

ping~

@lijiarui lijiarui requested a review from huan June 4, 2019 10:58
@lijiarui
Copy link
Member

lijiarui commented Jun 4, 2019

LGTM，How about @huan

@huan
Copy link
Member

huan commented Jun 4, 2019

@lijiarui I don't think so.

The docs/index.md is generated from src/**/*.ts, which means that we should never modify it directly.

What @xinbenlv want to fix should be at the location of:

https://github.com/Chatie/wechaty/blob/21ff9ca288c610d96e69c20eb836874344afc717/src/wechaty.ts#L374-L375

huan
huan requested changes Jun 4, 2019
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this issue in the wechaty.ts instead of the index.md

@lijiarui
Copy link
Member

lijiarui commented Jun 4, 2019

@huan Yes, you are right. I forgot this.

@huan
Copy link
Member

huan commented Jun 15, 2019

ping @xinbenlv

@huan
Copy link
Member

huan commented Jun 26, 2019

kindly ping @xinbenlv

@xinbenlv
Copy link
Contributor Author

Sorry missed this notification.

xinbenlv added a commit to xinbenlv/wechaty that referenced this pull request Jul 12, 2019
@xinbenlv
Fix comment, in replacing wechaty#1784
d46ced2
@xinbenlv xinbenlv mentioned this pull request Jul 12, 2019
Merged
@xinbenlv
Copy link
Contributor Author

Replaced by #1814

@xinbenlv xinbenlv closed this Jul 12, 2019
@huan huan added the duplicate label Jul 12, 2019
huan pushed a commit that referenced this pull request Jul 12, 2019
@xinbenlv @huan
Fix comment, in replacing #1784 (#1814)
b5b4131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huan huan huan requested changes

@lijiarui lijiarui lijiarui approved these changes

Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xinbenlv @lijiarui @huan