+1 to @windmemory, the delete method needs to identify which tag is this operation operated on.

@huan
After a second thought, I think we should make it clear about what c in c.tag() is. If c is Contact class, I doubt if the previous reply works.

There is a One-to-Many relation between Contact and Tag(to Tag(string))

I think we can do this (the Contact-level interfaces)

class Contact {
   public addTag(tagName)
   public removeTag(tagName)
   public getTagList():string[]
}

and there should be WeChaty instance level interfaces

// I forgot exact interface
class Wechaty { 
  public getTagList():string[] // I am really really NOT a big fan of omitting semicolon :( 
  public updateTag(oldTag, newTag) // create by setting oldTag to null, or delete by setting newTag to null
  public findByTag(tag):Contact[]
}

Also I mentioned there is a number representation and it's a ordered list in the PadChat implementation is because it's possible there is a out-of-sync if a user logged in the Wechaty and on their phone they update a Tag(string), so I like to discuss whether we want to find way to force sync tagList before updating any list. If so

class Wechaty {
  public updateTagList();
}

Note: might need to make some function interfaces async.

Uh oh!

支持标签功能 #1627

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions