Docker image : add healthcheck, linting and run as regular user #1433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CAMPION Hugo <h.campion@geco-it.fr>
Signed-off-by: CAMPION Hugo <h.campion@geco-it.fr>
|
Looking good, thank you! |
|
@all-contributors please add @hugosxm for code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
After reading on that issue : #1302
I've made the docker image non root, I tested creating a user and making ssh connection and it worked.
I also added a healthcheck, but we need a proper healthcheck endpoint for that, see #1432
And there is some linting / best practices, the only thing i disabled is the hadolint check that wants you to pin version.
See here : https://github.com/hadolint/hadolint/wiki/DL3008