Support ldflags when building multi binaries #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will it be a breaking change or not? |
Doesn't look like it https://github.com/wangyoucao577/go-release-action/actions/runs/12238801736/job/34200195336?pr=180 |
|
Thanks very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support ldflags when building multi binaries. This PR is a redo of #178 that also handles empty
ldflags.Because
INPUT_LDFLAGSis always an argument to go build, even when empty, prefixing it withLDFLAGS_PREFIXwill either use any flags or pass in an empty list of flags.The issue with the previous PR is that the prefix was empty but the flags argument was being passed (due to double quotes):
With this PR, the above call should look like: