Skip to content

Correct assertEquals argument order #1499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2025
Merged

Correct assertEquals argument order #1499

merged 2 commits into from
Apr 26, 2025

Conversation

liblit
Copy link
Contributor

@liblit liblit commented Apr 26, 2025

JUnit 5's assertEquals method should be called with the expected value first and the actual value second.

@liblit
Correct assertEquals argument order
bbb1afc 
JUnit 5's `assertEquals` method should be called with the _expected_
value _first_ and the _actual_ value _second_.
@liblit liblit added the cleanup API cleanup and refactoring label Apr 26, 2025
@liblit liblit requested a review from msridhar April 26, 2025 22:52
@liblit liblit self-assigned this Apr 26, 2025
@liblit liblit enabled auto-merge (rebase) April 26, 2025 22:53
msridhar
msridhar approved these changes Apr 26, 2025
View reviewed changes
Copy link
Member

@msridhar msridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@liblit liblit merged commit 458702a into wala:master Apr 26, 2025
10 checks passed
@liblit liblit deleted the correct-assertEquals-argument-order branch April 26, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msridhar msridhar msridhar approved these changes

Assignees

@liblit liblit

Labels
cleanup API cleanup and refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liblit @msridhar