Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: wala/WALA
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.6.8
Choose a base ref
...
head repository: wala/WALA
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.6.9
Choose a head ref
  • 8 commits
  • 19 files changed
  • 2 contributors

Commits on Nov 22, 2024

  1. Configuration menu
    Copy the full SHA
    ee5f071 View commit details
    Browse the repository at this point in the history
  2. Update to Error Prone 2.36.0 (#1469)

    The new
    [DuplicateBranches](https://errorprone.info/bugpattern/DuplicateBranches)
    check caught some cases which I tried to comment out more clearly for
    readability.
    msridhar authored Nov 22, 2024
    Configuration menu
    Copy the full SHA
    b99a80f View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2024

  1. Update Google Java Format to 1.25.0 (#1470)

    Just to stay up to date
    msridhar authored Nov 23, 2024
    Configuration menu
    Copy the full SHA
    56efabd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a44aa59 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. Don't update CHACallGraph internal target cache from CallGraph getter…

    … methods (#1473)
    
    We should only update `targetCache` when computing the call graph, not
    when reading its current state. When debugging another issue, I ran into
    very confusing behavior where the debugger invoked `toString()` on a
    `CHACallGraph` to display its state, which ended up updating
    `targetCache` (whose state I was trying to debug) by calling an accessor
    method.
    msridhar authored Nov 26, 2024
    Configuration menu
    Copy the full SHA
    bc3d141 View commit details
    Browse the repository at this point in the history
  2. Some tweaks to @Initializer annotations in wala.util (#1474)

    - Remove a couple of `@Nullable` annotations and add `@Initializer`
    instead, to better capture the protocol.
    - Remove WALA's custom `@Initializer` annotation and use the one from
    NullAway's annotations package, which we already depend on.
    msridhar authored Nov 26, 2024
    Configuration menu
    Copy the full SHA
    6d62392 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2024

  1. Add lambda support to CHACallGraph (#1476)

    Fixes #1459 
    
    To support lambdas, we re-use logic from the
    `LambdaMethodTargetSelector` to handle calls that use `invokedynamic`.
    `CHACallGraph` only includes edges for methods reachable from given
    entrypoints, and our handling of lambdas adds new synthetic classes to
    the class hierarchy (representing the classes generated for lambdas). So
    to ensure a complete call graph, we do a second pass after adding these
    synthetic classes to recompute call targets. This is probably not the
    most efficient way to do things, but I'm not sure it's the bottleneck;
    if we need to optimize in the future we should do so based on profiling.
    
    Note that the handling of lambdas here is very imprecise; every call
    site of a functional interface method will have an edge to every lambda
    of that functional interface type. Still, it could be practically
    useful, e.g., when combined with other heuristic filtering of irrelevant
    code.
    
    We add new tests, and also fix a couple other minor bugs (e.g., there
    was no edge before to the synthetic method that invokes class
    initializers, so it wasn't being processed properly).
    
    ---------
    
    Co-authored-by: Ben Liblit <liblit@acm.org>
    msridhar and liblit authored Nov 30, 2024
    Configuration menu
    Copy the full SHA
    9f71651 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. Prepare for release 1.6.9.

    msridhar committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    7a5f388 View commit details
    Browse the repository at this point in the history
Loading