Skip to content

Support self-signed certificates #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

Support self-signed certificates #187

merged 1 commit into from
Mar 10, 2025

Conversation

mortymacs
Copy link
Member

@mortymacs mortymacs commented Jun 3, 2023 •
edited by atkrad
Loading

Resolve #95

@mortymacs mortymacs requested a review from atkrad June 3, 2023 12:51
@coveralls
Copy link

coveralls commented Jun 3, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 13765453334

Details

  • 39 of 71 (54.93%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 50.418%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/cmd/http.go 25 29 86.21%
checker/http/http.go 14 42 33.33%
Totals Coverage Status
Change from base Build 13764045733: 0.009%
Covered Lines: 1205
Relevant Lines: 2390
💛 - Coveralls

@mortymacs mortymacs force-pushed the support-http-self-signed branch 2 times, most recently from 32410df to 4266fee Compare March 5, 2025 20:43
@atkrad
Copy link
Member

atkrad commented Mar 6, 2025

@mortymacs Please fix the pipeline 😃

@mortymacs
Copy link
Member Author

@mortymacs Please fix the pipeline 😃

Done :)

atkrad
atkrad reviewed Mar 7, 2025
View reviewed changes
@atkrad atkrad added the feature New feature or request label Mar 7, 2025
@mortymacs mortymacs force-pushed the support-http-self-signed branch from a4a9a48 to de568a5 Compare March 10, 2025 13:08
@atkrad atkrad merged commit f970a04 into main Mar 10, 2025
6 of 7 checks passed
@atkrad atkrad deleted the support-http-self-signed branch March 29, 2025 07:55
@koelle25
Copy link

Thanks for this feature!

Unfortunately I don't really know how to use it, can you add an Example to the docs? Probably best under Detailed Usage > HTTP Checking

@mortymacs
Copy link
Member Author

mortymacs commented May 19, 2025 •
edited
Loading

Thanks for this feature!

Unfortunately I don't really know how to use it, can you add an Example to the docs? Probably best under Detailed Usage > HTTP Checking

Hi, 😊

Good point! I'll go ahead and update the document. In the meantime, you can check out some examples here https://github.com/wait4x/wait4x/blob/main/internal/cmd/http.go#L96-L100

@mortymacs
Copy link
Member Author

@koelle25 As promised, I've just submitted a PR for it #418 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atkrad atkrad atkrad approved these changes

Assignees

@mortymacs mortymacs

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support self-signed TLS certiticate on HTTP component
4 participants
@mortymacs @coveralls @atkrad @koelle25