One word fix for slightly awkward phrasing #449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now when running e.g. `wait4x exec true`, the output shows "Checking the true", which is awkward grammatically.
"Checking true" would be slightly better, or even better would be some message which is specific to the kind of condition being waited on ("Checking execution of true") but the latter seems more invasive of a change, so perhaps just dropping "the" is acceptable?
Pull Request Test Coverage Report for Build 16477492417Details
💛 - Coveralls |
atkrad
approved these changes
Jul 23, 2025
|
@Julian Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now when running e.g.
wait4x exec true, the output shows "Checking the true", which is awkward grammatically."Checking true" would be slightly better, or even better would be some message which is specific to the kind of condition being waited on ("Checking execution of true") but the latter seems more invasive of a change, so perhaps just dropping "the" is acceptable?