Skip to content

Conversation

atkrad
Copy link
Member

@atkrad atkrad commented May 10, 2025

Potential fix for https://github.com/wait4x/wait4x/security/code-scanning/1

To fix the issue, we will add a permissions block to the workflow. Since the workflow primarily involves checking code formatting, running tests, and generating coverage reports, it only requires contents: read permissions. This will restrict the GITHUB_TOKEN to read-only access to the repository contents, adhering to the principle of least privilege.

The permissions block will be added at the root level of the workflow to apply to all jobs (check, test, and build). If any job requires additional permissions in the future, they can be specified within that job's configuration.


Suggested fixes powered by Copilot Autofix. Review carefully before merging.

…n permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@atkrad atkrad marked this pull request as ready for review May 10, 2025 07:51
@atkrad atkrad merged commit d401f03 into main May 10, 2025
5 checks passed
@atkrad atkrad deleted the fix-check-permissions branch May 10, 2025 07:53
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14943359435

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.418%

Totals Coverage Status
Change from base Build 14915934441: 0.0%
Covered Lines: 1205
Relevant Lines: 2390

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants