Remove golang.org/x/exp dependency
#1047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The experimental functions in `golang.org/x/exp/slices` are now available in the standard library in Go 1.21 [1]. [1]: https://go.dev/doc/go1.21#slices Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
|
Thanks 👍 yeah maybe would be nice to remove golang.org/x/exp dependency completely then. Feel free to amend that to this PR or create a new PR for it. |
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
exp/slices package with standard librarygolang.org/x/exp dependency
Done! Please take a look again. Thanks 😊 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The experimental functions in
golang.org/x/exp/slicesare now included in the standard library since Go 1.21 1.However, we cannot remove the
golang.org/x/expdependency yet because we still rely on thegolang.org/x/exp/constraintspackage, which has not yet been included into the standard library (golang/go#61914).An alternative approach is to create our own implementation, e.g.
constraints.golike this PR hashicorp/terraform-plugin-testing#260 so we can remove thegolang.org/x/expdependency completely.fq/format/apple/loop_detector.go
Line 4 in 4e3ab79
fq/internal/mathx/num.go
Line 11 in 4e3ab79
Footnotes
https://go.dev/doc/go1.21#slices ↩