fix bounds error when diffing pathologically different large files #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you provide a reproducer and add a test case that demonstrate the fix please ? |
|
@meekmichael Could you share the JSON documents that trigger this case please ? I'm interested in seeing how the |
|
The documents are company private, but I can say that they're moderately nested with large arrays of maps. I have been spending some time trying to make a reproduction case, but I still struggle. I suspect its an off-by-one error of some sort. This happens when we diff two very large docs with the same structure but largely different data. Given time I may be able to sanitize these files with random strings, but I don't have time this week. |
wI2L
added a commit
that referenced
this pull request
Nov 11, 2024
|
@meekmichael Fixed. Will release a new tag ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing
LCSdiffs of very large and very different files we would keep seeing crashes when calling theprependfunction. Adding this (dumb) check fixes it, it appears that whenstartIdxis at the end of the array, the array isn't yet large enough to accommodate this operation.