Skip to content

fix: encoding of a zero-value duration in string format #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

wI2L
Copy link
Owner

@wI2L wI2L commented Oct 21, 2021

Instead of returning the constant byte slice containing the
representation of the zero duration, appends its content to
the destination slice.

resolve #2

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #3 (431df32) into master (ec04aa1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #3   +/-   ##
=======================================
  Coverage   95.75%   95.75%           
=======================================
  Files          13       13           
  Lines        1200     1200           
=======================================
  Hits         1149     1149           
  Misses         33       33           
  Partials       18       18           
Impacted Files Coverage Δ
time.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec04aa1...431df32. Read the comment docs.

@wI2L wI2L force-pushed the fix-issue-2 branch 3 times, most recently from a665a07 to a7a2a9b Compare October 21, 2021 23:21
Instead of returning the constant byte slice containing the
representation of the zero duration, appends its content to
the destination slice.

resolve #2
@wI2L wI2L self-assigned this Nov 2, 2021
@wI2L wI2L added the bug Something isn't working label Nov 2, 2021
@wI2L wI2L merged commit b174f9b into master Nov 2, 2021
@wI2L wI2L deleted the fix-issue-2 branch November 2, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

durationFormat error
1 participant