Skip to content

Set galah/dereplication as a crate feature #50

@apcamargo

Description

@apcamargo

Hey Ben,

I know that CoverM isn't supposed to be used as a library and that implementing this would require some work, so feel free to ignore/close this issue if you think it is not worth it.

I just updated pyCoverM to use the latest release (0.6.0) and I noticed that I can't compile the wheel on Windows because of Galah:

error[E0433]: failed to resolve: could not find `unix` in `os`
   --> C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\galah-0.3.0\src\cluster_argument_parsing.rs:385:22
    |
385 |             std::os::unix::fs::symlink(link, std::path::Path::new(&current_stab)).expect(&format!(
    |                      ^^^^ could not find `unix` in `os`

Because dereplication is not something that most people would expect in a tool to estimate contig/genome coverage, maybe it could be moved to the [features] section of the Cargo.toml file and then Galah could be marked as an optional requirement. This way, CoverM could be compiled on Windows.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions