Skip to content

Conversation

xerial-bot
Copy link
Collaborator

About this PR

πŸ“¦ Updates

from 1.11.3 to 1.11.4

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-sbt" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-sbt" }
}]
labels: library-update

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates the update of several core Scala Build Tool (sbt) components and related plugins to their latest patch version, 1.11.4. The primary goal is to ensure the project leverages the most recent stable releases, benefiting from any bug fixes or minor improvements introduced in this patch version. This is a routine maintenance update to keep the build environment current.

Highlights

  • sbt Update: The core sbt build tool has been updated from version 1.11.3 to 1.11.4.
  • sbt-dependency-tree Update: The sbt-dependency-tree plugin has been updated from version 1.11.3 to 1.11.4.
  • scripted-plugin Update: The scripted-plugin has been updated from version 1.11.3 to 1.11.4.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with πŸ‘ and πŸ‘Ž on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the sbt version from 1.11.3 to 1.11.4 across all build.properties files. The update is a safe patch release. While the changes themselves are correct, I've added a comment regarding the maintainability of having the sbt version duplicated across multiple files and suggested a CI check to mitigate the risk of future inconsistencies during manual updates. Otherwise, the PR looks good to merge.

@@ -11,4 +11,4 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
sbt.version=1.11.3
sbt.version=1.11.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this PR correctly updates the sbt version across all modules, the fact that the version is duplicated in 6 different build.properties files poses a maintenance risk. A manual update could easily miss one of the files, leading to inconsistent sbt versions within the monorepo, which could cause subtle build issues. To mitigate this risk, I recommend adding a CI check that verifies all sbt.version properties are identical across the repository. This would safeguard against future inconsistencies.

@xerial xerial merged commit bc554f0 into main Aug 8, 2025
20 checks passed
@xerial xerial deleted the update/sbt-1.11.4 branch August 8, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants