Skip to content

Update grpc-netty-shaded, grpc-protobuf to 1.74.0 #4000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2025
Merged

Update grpc-netty-shaded, grpc-protobuf to 1.74.0 #4000

merged 1 commit into from
Aug 13, 2025

Conversation

xerial-bot
Copy link
Collaborator

About this PR

📦 Updates

from 1.73.0 to 1.74.0

📜 GitHub Release Notes - Version Diff

Usage

✅ Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "io.grpc" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "io.grpc" }
}]
labels: library-update

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 28, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the gRPC dependencies, specifically grpc-netty-shaded and grpc-protobuf, to version 1.74.0. This is a routine dependency update to ensure we are using the latest stable versions of these libraries, which can bring performance improvements, bug fixes, and new features from the gRPC project.

Highlights

  • Dependency Version Bump: The GRPC_VERSION in build.sbt has been updated from 1.73.0 to 1.74.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 28, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the gRPC version from 1.73.0 to 1.74.0. This is a routine dependency update from Scala Steward. While the change itself is simple, I've identified a potential dependency mismatch with protobuf-java that could lead to runtime issues. I've provided a suggestion to manage the protobuf-java version more explicitly to ensure compatibility and improve maintainability.

build.sbt
@@ -21,7 +21,7 @@ val JS_JAVA_TIME_VERSION = "1.0.0"
val SCALAJS_DOM_VERSION = "2.8.0"
val FINAGLE_VERSION = "24.2.0"
val FLUENCY_VERSION = "2.7.3"
val GRPC_VERSION = "1.73.0"
val GRPC_VERSION = "1.74.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This update to gRPC 1.74.0 might require a corresponding update to the protobuf-java dependency. The benchmark module (line 942) has a hardcoded dependency on com.google.protobuf:protobuf-java:"3.25.8". Mismatched versions between grpc-protobuf and protobuf-java can cause runtime errors.

To improve maintainability and prevent potential issues, it's better to manage the protobuf-java version in a val alongside GRPC_VERSION. The suggested code introduces a PROTOBUF_VERSION variable. The compatible protobuf-java version for gRPC 1.74.0 should be used, and line 942 in the benchmark module should be updated to use this new variable. This will help keep these related dependencies in sync.

val PROTOBUF_VERSION                = "3.25.8" // This may need to be updated for gRPC v1.74.0
val GRPC_VERSION                    = "1.74.0"

@xerial xerial merged commit 0be1829 into main Aug 13, 2025
19 of 20 checks passed
@xerial xerial deleted the update/grpc-netty-shaded-1.74.0 branch August 13, 2025 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
library-update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xerial-bot @xerial