Skip to content

Update grpc-netty-shaded, grpc-protobuf, ... to 1.73.0 #3924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

Update grpc-netty-shaded, grpc-protobuf, ... to 1.73.0 #3924

merged 1 commit into from
May 29, 2025

Conversation

xerial-bot
Copy link
Collaborator

About this PR

📦 Updates

from 1.72.0 to 1.73.0

📜 GitHub Release Notes - Version Diff

Usage

✅ Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

🔍 Files still referring to the old version number

The following files still refer to the old version number (1.72.0).
You might want to review and update them manually.

website/static/img/undraw_monitor.svg
⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "io.grpc" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "io.grpc" }
}]
labels: library-update

@amazon-q-developer Amazon Q Developer
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

gemini-code-assist[bot]
gemini-code-assist bot reviewed May 27, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello team, Gemini here to provide a quick summary of this pull request. This PR, automatically generated by xerial-bot (likely Scala Steward), is a routine dependency update. Its primary goal is to upgrade the gRPC libraries used in the project, specifically grpc-netty-shaded, grpc-protobuf, and grpc-stub, from version 1.72.0 to 1.73.0. The change is straightforward, involving a single modification to the build configuration file.

Highlights

  • Dependency Update: The core purpose of this PR is to update the project's dependency on the gRPC libraries (grpc-netty-shaded, grpc-protobuf, grpc-stub) to the latest version, 1.73.0.
  • Build Configuration Change: The update is implemented by changing the version constant for gRPC within the build.sbt file.

Changelog

  • build.sbt
    • Updated the GRPC_VERSION constant from 1.72.0 to 1.73.0 on line 24.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Version number bumps,
Bot brings updates, code flows,
New features arrive.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed May 27, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Scala Steward, updates the gRPC dependencies (grpc-netty-shaded, grpc-protobuf, grpc-stub) from version 1.72.0 to 1.73.0.

I've reviewed the linked gRPC-Java v1.73.0 release notes. The update includes several bug fixes (e.g., NettyServerHandler NPE, RLS race condition, BinderChannel memory leak) and makes Context.Storage a stable API. There are no apparent breaking changes that would affect this project for a minor version bump.

The change in build.sbt correctly updates the GRPC_VERSION variable.

One minor point, as noted by Scala Steward in the PR description, is that the file website/static/img/undraw_monitor.svg might still refer to the old version number (1.72.0). This is likely an embedded text or metadata within the image and may require manual review and update if it's intended to reflect the current gRPC version used.

Overall, this update appears safe and beneficial due to the included bug fixes.

Summary of Findings

  • Stale version reference in SVG file: Scala Steward noted that website/static/img/undraw_monitor.svg might still refer to the old gRPC version 1.72.0. This is a minor point and can be addressed manually if the SVG is intended to display or reference the current gRPC version. This was not added as a specific review comment due to the review settings focusing on medium or higher severity issues.

Merge Readiness

The pull request updates gRPC to a newer version which includes bug fixes and improvements. The code change itself is correct. Considering the nature of the update and the information from the release notes, this PR looks good to merge. As an AI reviewer, I am not authorized to approve pull requests; please ensure it passes all CI checks and gets a final review from a human maintainer if required. The point about the SVG file is minor and can be handled separately.

@amazon-q-developer Amazon Q Developer
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@xerial xerial merged commit 0021b55 into main May 29, 2025
17 checks passed
@xerial xerial deleted the update/grpc-netty-shaded-1.73.0 branch May 29, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
library-update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xerial-bot @xerial