Update scalajs-dom to 2.8.1 #3998
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request performs a routine dependency update, upgrading the scalajs-dom library to its latest patch version. This minor update aims to incorporate recent bug fixes and small improvements from the library, ensuring the project benefits from the most stable and up-to-date DOM manipulation capabilities for Scala.js applications.
Highlights
- Dependency Update: The
scalajs-domlibrary has been updated from version2.8.0to2.8.1. - Build Configuration Consistency: The version bump is applied to both the main
build.sbtand a testbuild.sbtfile, ensuring consistent dependency resolution across the project.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request from Scala Steward updates the scalajs-dom dependency to version 2.8.1. The changes are correct as-is.
I've added one suggestion to improve maintainability by replacing a hardcoded version string in a test build file with a system property. This aligns with existing practice in the same file and will make future version updates more robust.
As noted in the PR description, you may also want to manually update the old version number in the following files not included in this change:
airframe-http/src/main/scala/wvlet/airframe/http/RPCContext.scaladocs/airframe-rpc.mddocs/release-notes.md
| @@ -24,7 +24,7 @@ lazy val client = | |||
| ) | |||
| .jsSettings( | |||
| libraryDependencies ++= Seq( | |||
| "org.scala-js" %%% "scalajs-dom" % "2.8.0" | |||
| "org.scala-js" %%% "scalajs-dom" % "2.8.1" | |||
There was a problem hiding this comment.
To improve maintainability and avoid version discrepancies, it's better to avoid hardcoding the scalajs-dom version here. This test build file already uses a system property for the airframe.version.
A similar approach can be used for scalajs-dom's version. This would involve:
- Using a system property to read the version.
- Updating the build configuration that runs this test to pass the property, for example:
-Dscalajs-dom.version=2.8.1.
This ensures that the test always uses the version defined in the main build.sbt, reducing the chance of inconsistencies when versions are updated manually.
"org.scala-js" %%% "scalajs-dom" % sys.props.getOrElse("scalajs-dom.version", "2.8.1")
About this PR
📦 Updates org.scala-js:scalajs-dom from
2.8.0to2.8.1📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
🔍 Files still referring to the old version number
The following files still refer to the old version number (2.8.0).
You might want to review and update them manually.
⚙ Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: