fix: Handle JDBC Types.OTHER (1111) without warning #3995
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where JDBC type 1111 (
Types.OTHER
) generates an unnecessary warning message when processed by JDBCCodec.Problem
When JDBCCodec encounters JDBC type 1111 (
Types.OTHER
), it falls through to the default case which logs a warning:Types.OTHER
is a standard JDBC type used for database-specific types that don't fit into standard SQL types, so this warning is misleading and creates noise in logs.Solution
Added an explicit case for
Types.OTHER
in thetoJDBCColumnCodec
method to map it directly toJDBCStringCodec
without generating a warning. This maintains the existing behavior (treating it as a string) while eliminating the unnecessary warning.Changes
Types.OTHER
(1111)Types.OTHER
is handled correctly without warningsTesting
Types.OTHER
maps toJDBCStringCodec
without warningsThe fix is minimal and surgical - only one line added to handle this specific JDBC type while preserving all existing functionality.
Fixes #3994.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.