Skip to content

Conversation

xerial-bot
Copy link
Collaborator

About this PR

πŸ“¦ Updates com.squareup.okhttp3:okhttp from 4.12.0 to 5.1.0 ⚠

πŸ“œ Changelog

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.squareup.okhttp3", artifactId = "okhttp" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.squareup.okhttp3", artifactId = "okhttp" }
}]
labels: library-update

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is a routine dependency update, specifically targeting the okhttp library. The primary goal is to bring the project up to date with the latest stable version of okhttp, ensuring the integration benefits from recent improvements, bug fixes, and security enhancements provided by the library maintainers.

Highlights

  • Dependency Update: I've updated the okhttp library dependency from version 4.12.0 to 5.1.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with πŸ‘ and πŸ‘Ž on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates OkHttp from version 4.12.0 to 5.1.0. This is a major version upgrade. I've raised a concern about potential breaking changes and the need for thorough compatibility testing.

build.sbt Outdated
@@ -876,7 +876,7 @@ lazy val okhttp =
name := "airframe-http-okhttp",
description := "REST API binding for OkHttp",
libraryDependencies ++= Seq(
"com.squareup.okhttp3" % "okhttp" % "4.12.0"
"com.squareup.okhttp3" % "okhttp" % "5.1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This PR proposes a major version upgrade for OkHttp from 4.12.0 to 5.1.0. Major version upgrades can introduce breaking changes. Verify compatibility and test thoroughly, especially considering potential impacts on downstream users of airframe.

- Change artifact from 'okhttp' to 'okhttp-jvm' as required by OkHttp 5.x
- Clean up Response type references in package.scala for consistency
- All tests passing with OkHttp 5.1.0
@xerial xerial merged commit f10f300 into main Jul 19, 2025
17 checks passed
@xerial xerial deleted the update/okhttp-5.1.0 branch July 19, 2025 14:53
@xerial xerial added breaking Breaking changes and removed breaking Breaking changes labels Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants