-
Notifications
You must be signed in to change notification settings - Fork 70
Update sbt-dynver to 5.1.1 #3971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request performs a routine dependency upgrade, updating the sbt-dynver
plugin to its latest patch version, 5.1.1
. This minor version bump likely incorporates bug fixes or small improvements from the upstream library. Additionally, it includes minor, cosmetic formatting adjustments in two plugin.sbt
files.
Highlights
- Dependency Update: Updated the
sbt-dynver
plugin from version5.1.0
to5.1.1
acrossairspec/project/plugin.sbt
,project/plugin.sbt
, andsbt-airframe/project/plugin.sbt
. - Code Formatting: Applied minor whitespace adjustments to the
SCALAJS_VERSION
variable assignment inairspec/project/plugin.sbt
andproject/plugin.sbt
.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with π and π on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. β©
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, generated by Scala Steward, correctly updates the sbt-dynver
plugin from version 5.1.0
to 5.1.1
. The update is a patch release containing a bug fix and is applied consistently across the necessary build files.
I've noticed a couple of minor formatting changes that seem to have been introduced alongside the dependency update. These changes remove the alignment of a constant definition, which makes it inconsistent with the prevailing style in the project. I've added suggestions to revert these formatting changes to maintain code style consistency.
@@ -9,7 +9,7 @@ addSbtPlugin("com.eed3si9n" % "sbt-buildinfo" % "0.13.1") | |||
addDependencyTreePlugin | |||
|
|||
// For Scala.js | |||
val SCALAJS_VERSION = sys.env.getOrElse("SCALAJS_VERSION", "1.19.0") | |||
val SCALAJS_VERSION = sys.env.getOrElse("SCALAJS_VERSION", "1.19.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This formatting change removes the alignment for the =
operator. While functionally correct, it's inconsistent with the alignment style used for constants elsewhere in the project (e.g., in build.sbt
and other parts of this file). Restoring the alignment would maintain a more consistent code style.
val SCALAJS_VERSION = sys.env.getOrElse("SCALAJS_VERSION", "1.19.0")
@@ -19,7 +19,7 @@ addSbtPlugin("org.wvlet.airframe" % "sbt-airframe" % SBT_AIRFRAME_VERSION) | |||
addDependencyTreePlugin | |||
|
|||
// For Scala.js | |||
val SCALAJS_VERSION = sys.env.getOrElse("SCALAJS_VERSION", "1.19.0") | |||
val SCALAJS_VERSION = sys.env.getOrElse("SCALAJS_VERSION", "1.19.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This formatting change removes the alignment for the =
operator. While functionally correct, it's inconsistent with the alignment style used for constants elsewhere in the project (e.g., in the main build.sbt
file). Restoring the alignment would maintain a more consistent code style.
val SCALAJS_VERSION = sys.env.getOrElse("SCALAJS_VERSION", "1.19.0")
About this PR
π¦ Updates com.github.sbt:sbt-dynver from
5.1.0
to5.1.1
π GitHub Release Notes - Version Diff
Usage
β Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conf
file.Have a fantastic day writing Scala!
β Adjust future updates
Add this to your
.scala-steward.conf
file to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: