-
Notifications
You must be signed in to change notification settings - Fork 71
Update postgresql to 42.7.7 #3966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is an automated dependency update, bumping the version of the PostgreSQL JDBC driver used in the project. It also includes a minor formatting adjustment in the build file.
Highlights
- Dependency Update: Updates the
org.postgresql:postgresql
dependency from version42.7.6
to42.7.7
in thejdbc
project definition. - Build File Formatting: Includes a minor indentation change for an
exclude
rule in thefluentd
project definition withinbuild.sbt
. This appears to be a formatting change unrelated to the dependency update itself.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with π and π on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. β©
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request updates the PostgreSQL JDBC driver to version 42.7.7. There's also an indentation change to an exclude
rule in build.sbt
. The exclude
rule appears to be incorrectly formulated and positioned, likely rendering it ineffective. It's recommended to review the necessity and implementation of this exclusion rule.
build.sbt
Outdated
@@ -962,7 +962,7 @@ lazy val fluentd = | |||
"org.komamitsu" % "fluency-fluentd" % FLUENCY_VERSION, | |||
"org.komamitsu" % "fluency-treasuredata" % FLUENCY_VERSION | |||
// td-client-java -> json-simple happened to include junit 4.10 [CVE-2020-15250] | |||
exclude ("junit", "junit"), | |||
exclude ("junit", "junit"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation of this exclude
line has increased from 8 spaces to 10 spaces. For consistency with other elements in the Seq
(e.g., lines 962-963 and 967-968, which are indented by 8 spaces), this line should also be indented by 8 spaces.
More importantly, an ExclusionRule
like exclude("junit", "junit")
placed directly as an item in the libraryDependencies
sequence is unlikely to have the desired effect of excluding a transitive dependency.
To exclude junit
from a specific dependency (e.g., fluency-treasuredata
), the syntax would typically be:
"org.komamitsu" % "fluency-treasuredata" % FLUENCY_VERSION exclude("junit", "junit")
Or, for a project-level exclusion (if this fluentd
project is defined with .settings(...)
):
excludeDependencies += ExclusionRule("junit", "junit")
Please verify:
- If this exclusion is still necessary. The comment on line 964 refers to a CVE related to
junit
as a transitive dependency viatd-client-java -> json-simple
. A quick check suggestsjunit
might not be a transitive dependency oforg.komamitsu:fluency-treasuredata:2.7.3
through this path with current versions. - If the exclusion is necessary, it should be applied using the correct sbt syntax to ensure it's effective.
The current form is likely non-functional and could lead to confusion or a false sense of security regarding the CVE mentioned.
exclude ("junit", "junit"),
7dad25a
to
7df77ce
Compare
7df77ce
to
5dd09b8
Compare
About this PR
π¦ Updates org.postgresql:postgresql from
42.7.6
to42.7.7
π Changelog
Usage
β Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conf
file.Have a fantastic day writing Scala!
β Adjust future updates
Add this to your
.scala-steward.conf
file to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: