Skip to content

Update netty-all to 4.2.2.Final #3957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2025
Merged

Update netty-all to 4.2.2.Final #3957

merged 1 commit into from
Jun 7, 2025

Conversation

xerial-bot
Copy link
Collaborator

About this PR

📦 Updates io.netty:netty-all from 4.2.1.Final to 4.2.2.Final

Usage

✅ Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "io.netty", artifactId = "netty-all" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "io.netty", artifactId = "netty-all" }
}]
labels: library-update

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jun 5, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

As gemini-code-assist, I've reviewed this pull request. The primary goal of this PR, automatically generated by xerial-bot (likely via Scala Steward), is to update the project's dependency on io.netty:netty-all. Specifically, it bumps the version of this library from 4.2.1.Final to 4.2.2.Final. This is a straightforward version update.

Highlights

  • Dependency Version Bump: The core change is updating the io.netty:netty-all dependency to a newer version (4.2.2.Final).

Changelog

  • build.sbt
    • Updated the version of the io.netty:netty-all library within the netty project definition from 4.2.1.Final to 4.2.2.Final (line 837).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Dependency update,
A small change in build file,
Keep code fresh and safe.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jun 5, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR updates the netty-all dependency to version 4.2.2.Final. This is a straightforward dependency update, and the changes appear to be correct. I have a few minor suggestions.

Merge Readiness

The pull request updates the netty-all dependency. It is a small change and seems correct. I would recommend merging after addressing the comment about adding a reason for the update.

build.sbt
@@ -834,7 +834,7 @@ lazy val netty =
name := "airframe-http-netty",
description := "Airframe HTTP Netty backend",
libraryDependencies ++= Seq(
"io.netty" % "netty-all" % "4.2.1.Final"
"io.netty" % "netty-all" % "4.2.2.Final"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Updating the netty-all dependency is a good practice to ensure the project benefits from the latest bug fixes and performance improvements. However, it's crucial to verify that this update doesn't introduce any compatibility issues with the existing codebase. Consider adding a comment to remind future developers to check for compatibility when updating dependencies like this.

It would be helpful to add a comment briefly explaining why this update is being done (e.g., security patch, performance improvement).

        "io.netty" % "netty-all" % "4.2.2.Final" // Updated to 4.2.2.Final for [reason, e.g., security fix, performance improvement]

@xerial xerial merged commit e4c4f50 into main Jun 7, 2025
17 checks passed
@xerial xerial deleted the update/netty-all-4.2.2.Final branch June 7, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
library-update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xerial-bot @xerial