Skip to content

airframe-sql: Qualify outputColumns if AllColumns has qualifier #2763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2023
Merged

airframe-sql: Qualify outputColumns if AllColumns has qualifier #2763

merged 1 commit into from
Feb 19, 2023

Conversation

takezoe
Copy link
Member

@takezoe takezoe commented Feb 19, 2023 •
edited
Loading

To make it possible to resolve columns outside a sub-query that has qualified AllColumns like this:

select t2.name from A t1 inner join (select * from B) t2 using (id)

t2.name in the select clause cannot be resolved in this SQL.

@takezoe takezoe requested a review from xerial February 19, 2023 03:17
@codecov
Copy link

codecov bot commented Feb 19, 2023

Codecov Report

Merging #2763 (1a45aae) into master (310fe3f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2763   +/-   ##
=======================================
  Coverage   82.27%   82.27%           
=======================================
  Files         337      337           
  Lines       14175    14178    +3     
  Branches     2266     2293   +27     
=======================================
+ Hits        11662    11665    +3     
  Misses       2513     2513
Impacted Files Coverage Δ
...in/scala/wvlet/airframe/sql/model/Expression.scala 72.93% <100.00%> (+0.17%) ⬆️
...frame-rx/src/main/scala/wvlet/airframe/rx/Rx.scala 83.95% <0.00%> (-1.24%) ⬇️
...me-log/src/main/scala/wvlet/log/io/StopWatch.scala 81.05% <0.00%> (+0.20%) ⬆️
...rx/src/main/scala/wvlet/airframe/rx/RxRunner.scala 95.41% <0.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 310fe3f...1a45aae. Read the comment docs.

@xerial xerial merged commit aaa294a into wvlet:master Feb 19, 2023
@xerial
Copy link
Member

xerial commented Feb 19, 2023

Merged. Thanks

@xerial xerial added the bug label Feb 19, 2023
@takezoe takezoe mentioned this pull request Feb 19, 2023
Merged
xerial pushed a commit that referenced this pull request Feb 19, 2023
@takezoe
airframe-sql: Unqualify outputColumns if AllColumns doesn't have qual…
d649138 
…ifier (#2764)

#2763 wasn't enough 🙇‍♂️

Unqualifying is also necessary if `AllColumns` doesn't have a qualifier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xerial xerial xerial approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takezoe @xerial