airframe-sql: Further fix for resolveAggregationIndexes #2680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takezoe
commented
Dec 28, 2022
| case Alias(_, _, expr, _) => | ||
| expr | ||
| case other => | ||
| other |
There was a problem hiding this comment.
Reverted #2674 but added unwrapping Alias to avoid wrong SQL generation in GROUP BY clause.
takezoe
commented
Dec 28, 2022
| @@ -364,8 +367,6 @@ object TypeResolver extends LogSupport { | |||
| r.sourceColumn | |||
| case a: Alias => | |||
| findSourceColumn(a.expr) | |||
| case s: SingleColumn => | |||
| findSourceColumn(s.expr) | |||
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2680 +/- ##
==========================================
- Coverage 82.22% 82.20% -0.02%
==========================================
Files 337 337
Lines 14074 14065 -9
Branches 2186 2196 +10
==========================================
- Hits 11572 11562 -10
- Misses 2502 2503 +1
Continue to review full report at Codecov.
|
be9627e to
b90263a
Compare
xerial
approved these changes
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous pull request (#2674) caused unresolved grouping keys in some cases.
I think
resolveSortItemIndexesmay need the same fix, but not 100% sure.