Skip to content

Conversation

takezoe
Copy link
Member

@takezoe takezoe commented Dec 27, 2022

No description provided.

@takezoe takezoe force-pushed the resolve-nested-all-columns branch from 9eebcb2 to 50693ec Compare December 27, 2022 10:53
@takezoe takezoe requested a review from xerial December 27, 2022 10:53
@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Merging #2673 (50693ec) into master (322dc47) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2673      +/-   ##
==========================================
- Coverage   82.33%   82.32%   -0.01%     
==========================================
  Files         335      335              
  Lines       14047    14051       +4     
  Branches     2214     2207       -7     
==========================================
+ Hits        11565    11567       +2     
- Misses       2482     2484       +2     
Impacted Files Coverage Δ
...in/scala/wvlet/airframe/sql/model/Expression.scala 71.11% <100.00%> (+0.43%) ⬆️
...frame-rx/src/main/scala/wvlet/airframe/rx/Rx.scala 83.95% <0.00%> (-1.24%) ⬇️
...rx/src/main/scala/wvlet/airframe/rx/RxRunner.scala 94.88% <0.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 322dc47...50693ec. Read the comment docs.

Copy link
Member

@xerial xerial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks

@xerial
Copy link
Member

xerial commented Dec 27, 2022

It seems we have two cases where we want to retain AllColumns(*) or a single column

For example, select * from (select * from ...), we want to preserve AllColumns in the input attributes, but for just checking input columns, we need to extract an input column as in this PR.

Maybe adding an abstraction like AttributeList(inputAttributes: List[Attribute]) might be necessary to cover different use cases.

@xerial
Copy link
Member

xerial commented Dec 27, 2022

For now we have inputColumns and inputAttributes, so we can use them for different purposes.

@xerial xerial merged commit 9a387b7 into wvlet:master Dec 27, 2022
@xerial xerial added the bug label Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants