Skip to content

fix: allow decimal viewport dimensions in fixed-layout #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2023
Merged

fix: allow decimal viewport dimensions in fixed-layout #1504

merged 1 commit into from
Apr 28, 2023

Conversation

rdeltour
Copy link
Member

The spec only says dimensions must be a "positive number" (or keyword), it does not specifically forbid decimal values.

Fix #1481

@rdeltour
fix: allow decimal viewport dimensions in fixed-layout
fc5e360 
The spec only says dimensions must be a "positive number" (or keyword), it does not specifically forbid decimal values.

Fix #1481
@rdeltour rdeltour added this to the Next maintenance release milestone Apr 28, 2023
@rdeltour rdeltour requested a review from mattgarrish April 28, 2023 13:06
@rdeltour rdeltour self-assigned this Apr 28, 2023
@rdeltour rdeltour linked an issue Apr 28, 2023 that may be closed by this pull request
Viewport in decimals generating ERROR #1481
Closed
Base automatically changed from fix/1482/pdf-fragment to main April 28, 2023 15:19
@rdeltour rdeltour merged commit fc5e360 into main Apr 28, 2023
@rdeltour rdeltour deleted the fix/1481/viewport-non-integer branch April 28, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattgarrish mattgarrish mattgarrish approved these changes

Assignees

@rdeltour rdeltour

Labels
None yet
Projects
None yet
Milestone
v5.0.1
Development

Successfully merging this pull request may close these issues.

Viewport in decimals generating ERROR
2 participants
@rdeltour @mattgarrish