feat: update viewport meta element requirements #1460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements the post-CR changes on the requirements for the viewport meta element used to define the ICB in fixed-layout documents. Viewport syntax: - properties can now have several values - the `ViewportMeta` object now return a list of string values when looking up values for a name. ICB definition checks: - only the first `viewport` `meta` element of fixed-layout documents is checked - new `HTM-059` error is reported when `height` or `width` dimensions are specified more than once - new `HTM-060a` usage is reported for any subsequent `viewport` `meta` element found in fixed-layout documents - new `HTM-060b` usage is reported fo any `viewport` `meta` element found in reflowable documents Fix #1401, Fix #1449
mattgarrish
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update viewport checks
This PR implements the post-CR changes on the requirements for the
viewport meta element used to define the ICB in fixed-layout documents.
Viewport syntax:
ViewportMetaobject now return a list of string values when looking up values for a name.ICB definition checks:
viewportmetaelement of fixed-layout documents is checkedHTM-059error is reported whenheightorwidthdimensions are specified more than onceHTM-060ausage is reported for any subsequentviewportmetaelement found in fixed-layout documentsHTM-060busage is reported fo anyviewportmetaelement found in reflowable documentsFix #1401, Fix #1449
Other changes