Skip to content

remove 'ERROR' in the informative "under review" message #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2019
Merged

remove 'ERROR' in the informative "under review" message #1059

merged 1 commit into from
Jul 18, 2019

Conversation

rdeltour
Copy link
Member

This addresses the concern raised by @ShinyaTakami in #1056.

@ShinyaTakami can you please review?

@rdeltour
refactor: remove 'ERROR' in the INF_001 message
a00e1db 
This addresses the concern raised by @ShinyaTakami in #1056.
@rdeltour rdeltour added this to the 4.2.2 milestone Jul 18, 2019
@rdeltour rdeltour self-assigned this Jul 18, 2019
@shiestyle
Copy link

I confirmed, thank you!

@rdeltour rdeltour merged commit 11747ab into master Jul 18, 2019
@rdeltour rdeltour deleted the fix/future-change-message branch July 18, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@shiestyle shiestyle shiestyle approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@rdeltour rdeltour

Labels
None yet
Projects
None yet
Milestone
4.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@rdeltour @shiestyle