Skip to content

Conversation

mattgarrish
Copy link
Member

@mattgarrish mattgarrish commented Apr 25, 2021

Includes an informative reference to charmod-norm for more information.

Fixes #1631


Preview | Diff

Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That may be a respec bug, but the charmod reference is put into the list of normative references! It may be that the "note" part has to be put into an explicit note to make the reference informative...

@mattgarrish
Copy link
Member Author

Looks like they changed respec so you don't use exclamation points at all now. To override a reference in a normative section and make it informative you use ?. See https://respec.org/docs/#references

@iherman
Copy link
Member

iherman commented Apr 26, 2021

Looks like they changed respec so you don't use exclamation points at all now. To override a reference in a normative section and make it informative you use ?. See https://respec.org/docs/#references

Wow. I did not realize this!

@mattgarrish
Copy link
Member Author

Ya, I'm sure it's broken other references we have. I've fixed the three in this PR for now, but will do a more thorough check of all the specs and clean them up again.

@iherman
Copy link
Member

iherman commented Apr 26, 2021

Sigh. I do not like such backward compatible changes. Oh well... let that be the fight of somebody else...

@iherman iherman self-requested a review April 26, 2021 11:41
@mattgarrish mattgarrish merged commit f430175 into main Apr 27, 2021
@mattgarrish mattgarrish deleted the fix/issue-1631 branch April 27, 2021 15:17
@xfq
Copy link
Member

xfq commented May 22, 2021

Glad to see that you have referred to charmod-norm. It would be useful to mention the order of Unicode normalization and Unicode full case folding, i.e., normalization should precede case folding.

(Related PR in charmod-norm: w3c/charmod-norm#215)

@iherman
Copy link
Member

iherman commented May 23, 2021

@xfq the text now says (in #1680, that is):

All File Names within the same directory MUST be unique following NFC normalization [[TR15]] and then case folding [[Unicode]].

(followed by the charmod reference, of course). Is that o.k.?

@xfq xfq added the i18n-tracker Group bringing to attention of Internationalization, or tracked by i18n but not needing response. label May 31, 2021
@xfq
Copy link
Member

xfq commented May 31, 2021

@iherman The current text says:

All File Names within the same directory MUST be unique following NFC normalization [TR15] and then full case folding [Unicode].

i18n WG discussed this in teleconference and I drew the action to respond here. We don't think it is necessary to mention NFC in the requirement. If you want to refer to charmod-norm normatively, you can refer to Unicode Canonical Case Fold Normalization Step.

If you want to refer to Unicode and UAX #15 normatively, you can change "NFC normalization" to "Unicode normalization" (or to "NFC or NFD normalization") so the spec won't limit people to NFC.

@iherman iherman mentioned this pull request May 31, 2021
@iherman
Copy link
Member

iherman commented May 31, 2021

@xfq I have created #1692 to handle this. The full paragraph now says:

<p id="ocf-fn-cn">All File Names within the same directory MUST be unique following Unicode 
normalization [[UAX15]] and then full case folding [[Unicode]]. (Refer to 
<a href="https://www.w3.org/TR/charmod-norm/#CanonicalFoldNormalizationStep">Unicode 
Canonical Case Fold Normalization Step</a> [[?CHARMOD-NORM]] for more information.)</p>

Can you approve or comment on #1692? Thx.

@aphillips
Copy link

One small addendum. There are four types of Unicode normalization: two canonical normalization forms (NFC/NFD) and two compatibility forms (NFKC/NFKD). You do not intend the Kompatibility forms to be used here, so I would at least say "Unicode canonical normalization".

@iherman
Copy link
Member

iherman commented Jun 1, 2021

One small addendum. There are four types of Unicode normalization: two canonical normalization forms (NFC/NFD) and two compatibility forms (NFKC/NFKD). You do not intend the Kompatibility forms to be used here, so I would at least say "Unicode canonical normalization".

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n-tracker Group bringing to attention of Internationalization, or tracked by i18n but not needing response.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Case folding of the file names
4 participants