Update to color properties in Forced Colors Mode #12166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, r-. Nothing wrong with the edits on their face, I just disagree with one of the resolutions this is implementing, and wrote my objection in #11857. |
tabatkins
requested changes
May 6, 2025
@tabatkins I also noticed a couple of other minor things when making the update that are now fixed in this PR:
|
tabatkins
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[css-color-adjust-1] This change makes the updates per resolutions taken in #11857.
More specifically, it moves the color properties that forced colors applies to within a note, mentions that this is the list at the time of writing and may not be exhaustive as other color properties are added over time, and notes that forced colors mode applies to any shorthand properties, as well.
It updates normative text referencing color properties to note that forced colors applies to the
<color>components of all properties.This change also updates
column-rule-colortorule-colorto ensure that full support exits for the new color properties added in the Gaps specification.It adds
accent-colorto the list of color properties (it is mentioned lower down in the algorithm (along withscrollbar-color) but it wasn't mentioned in the color properties list).I also updated some minor inconsistencies in using "computed" vs "computes" within the forced color mode rules.
Lastly, I updated the order of the color properties to be in alphabetical order.
The updates can be found hosted at https://alisonmaher.github.io/alisonmaher/css-color-adjust-1/Overview.html#forced-colors-properties.