Skip to content

Conversation

equalsJeffH
Copy link
Contributor

@equalsJeffH equalsJeffH commented Jul 27, 2018

fixes #712

This depends upon:

whatwg/infra#207 (fixes whatwg/infra#193), and

tc39/ecma262#1272 (which apparently depends to some degree on tc39/ecma262#1105)

At this point, we're waiting on the above to land before landing this.

cc: @annevk


Preview | Diff

@agl
Copy link
Contributor

agl commented Aug 1, 2018

Merging as requested on the call of 2018-08-01.

@agl agl merged commit bdc64c4 into master Aug 1, 2018
WebAuthnBot pushed a commit that referenced this pull request Aug 1, 2018
…ix-#712-json-serialized-client-data
WebAuthnBot pushed a commit that referenced this pull request Aug 1, 2018
…ix-#712-json-serialized-client-data
@equalsJeffH
Copy link
Contributor Author

urm... you folks merged this while I was still struggling with getting my audio connected. Anyway, I'd been thinking we oughta wait to merge this until the upstream dependencies have landed, see the orig post: #1017 (comment) -- I guess y'all didn't read the latter before pulling the trigger... :-/

@agl
Copy link
Contributor

agl commented Aug 2, 2018

I did check during and for some reason thought that both had been merged. It's possible that I opened the second link twice, however.

If we think that it's important it can be reverted until the deps are in place. Looks like the biggest risk is that the name changes in whatwg.

@equalsJeffH
Copy link
Contributor Author

thx @agl

as of now, whatwg folk are gonna merge whatwg/infra#207 and submit an issue or PR on webauthn since they're gonna change the operation name from what I'd proposed. see whatwg/infra#207 (comment)

and yes, tc39/ecma262#1272 is now merged, yay!

so, yeah, everything is falling into place and we're largely good here.

thx!

domenic added a commit to domenic/webauthn that referenced this pull request Aug 2, 2018
This is a follow-up to w3c#1017 to use the final name arrived at in whatwg/infra#207 and merged into the Infra Standard.
@emlun emlun deleted the jeffh-fix-#712-json-serialized-client-data branch August 7, 2018 15:20
equalsJeffH pushed a commit that referenced this pull request Aug 8, 2018
This is a follow-up to #1017 to use the final name arrived at in whatwg/infra#207 and merged into the Infra Standard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infra lacks a "JSON stringify and UTF-8 encode to bytes" operation JSON-serialized client data is wrong
2 participants