Hi,

I work at Intel, and we have developed a tool, named ControlFlag, that detects anomalous programming language expressions that can possibly lead to bugs. We scanned the code repository for this project, and we found a couple of places where the code/expressions are confusing and seem to implement the logic in a rather convoluted manner. We think that the expressions could be rewritten to capture the logic accurately and precisely.

Case 1) Expression (l_inbuf[2] | 1) in the following code seems confusing because it would always evaluate to true as per C language. Was the intention to say (l_inbuf[2] & 1)? This is in line 108 below

Case 2) Similarly, expression if (l_inbuf[3] | 1) seems confusing. Was the intention to say if (l_inbuf[3] & 1)? This is in line 114 below

Case 3) Similarly, expression if (l_inbuf[4] | 1) seems confusing for the same reason. This is in line 194 below

Case 4) For the same reason, expression if (l_inbuf[5] | 16) in line 199 look confusing.

I would be happy to fix these issues, if someone can confirm them as bugs.