Build only selected packages #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think it is mandatory, but it would eventually be nice to have a test of some kind that builds one package of many possibilities within a workspace-based project and builds only the MSI/installer for that one package. This is related to fully supporting workspaces. There are several issues and discussions related to workspaces but I am still unsure on a good implementation. This change is relatively small and easy to follow, so a test is not required, but thank you for asking. |
|
Thank you for the merge @volks73 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the build process:
if the end users selects a sub package of a workspace, the current code build each sub packages.
This PR limits the compilation to the selected sub packages
Note:
I don't see here a way to generate a regression test, as it may test if other sub packages are not build (maybe test the resulting tar directory?).
Do you think it's mandatory here?