Add support to HSDP model merging. #971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiyouga
approved these changes
Apr 8, 2025
zszheng
pushed a commit
to zszheng/verl
that referenced
this pull request
Apr 11, 2025
Currently the model merger does not support HSDP (the `ddp` mesh dim is not considered). This PR fixes this.
yuchenwang3
pushed a commit
to yuchenwang3/verl
that referenced
this pull request
Apr 25, 2025
Currently the model merger does not support HSDP (the `ddp` mesh dim is not considered). This PR fixes this.
yhyang201
pushed a commit
to yhyang201/verl
that referenced
this pull request
Apr 26, 2025
Currently the model merger does not support HSDP (the `ddp` mesh dim is not considered). This PR fixes this.
histmeisah
pushed a commit
to SJTU-IAAR/verl
that referenced
this pull request
Apr 27, 2025
Currently the model merger does not support HSDP (the `ddp` mesh dim is not considered). This PR fixes this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the model merger does not support HSDP (the
ddpmesh dim is not considered). This PR fixes this.