[rollout] fix: error in sgyang async mode #2098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed regression from: - volcengine#1668 - volcengine#1933 Added e2e test for both sglang and vllm async mode test
zhaochenyang20
approved these changes
Jun 19, 2025
There was a problem hiding this comment.
I am not sure why but the CI consistently times out on the sglang test. The last msg is:
(WorkerDict pid=20521) 2025-06-19 22:20:54,620 - INFO - flashinfer.jit: Loading JIT ops: batch_prefill_with_kv_cache_dtype_q_bf16_dtype_kv_bf16_dtype_o_bf16_dtype_idx_i32_head_dim_qk_64_head_dim_vo_64_posenc_0_use_swa_False_use_logits_cap_False_f16qk_False
(WorkerDict pid=20521) 2025-06-19 22:20:54,621 - INFO - flashinfer.jit: Loading JIT ops: batch_prefill_with_kv_cache_dtype_q_bf16_dtype_kv_bf16_dtype_o_bf16_dtype_idx_i32_head_dim_qk_64_head_dim_vo_64_posenc_0_use_swa_False_use_logits_cap_False_f16qk_False
I think this is right |
yellowbee686
pushed a commit
to yellowbee686/verl
that referenced
this pull request
Jun 23, 2025
Fixed regression from: - volcengine#1668 - volcengine#1933 Added e2e test for both sglang and vllm async mode test
Tyizhanshen
pushed a commit
to HyperdriveHustle/verl
that referenced
this pull request
Jul 1, 2025
Fixed regression from: - volcengine#1668 - volcengine#1933 Added e2e test for both sglang and vllm async mode test
whatadayG
pushed a commit
to whatadayG/verl
that referenced
this pull request
Sep 5, 2025
Fixed regression from: - volcengine#1668 - volcengine#1933 Added e2e test for both sglang and vllm async mode test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed regression from:
Added e2e test for both sglang and vllm async mode test