[rollout] misc: add demo chat completion scheduler described in ReTool paper #1297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
PeterSH6
approved these changes
May 4, 2025
There was a problem hiding this comment.
The multi-turn and tool-calling examples LGTM.
However, for the single-turn generation, I think we could simplify the workflow without using the ChatScheduler.
But we can merge this PR in advance.
I believe we should set up a meeting to discuss a better "ChatScheduler" to generalize single-turn/multi-turn/tool calling scenarios:
- General for all kinds of rollout backends
- A suitable scheduler for single-turn/multi-turn and can handle per-request callback
- Can be called by any environments
ScottCTD
pushed a commit
to ScottCTD/verl
that referenced
this pull request
May 5, 2025
…l paper (volcengine#1297) Co-authored-by: shengguangming <shengguangming@bytedance.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.