clean utils code. #1290
Merged
clean utils code. #1290
+8
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiyouga
previously approved these changes
Apr 28, 2025
2d8cf3f to
86b3003
Compare
|
use |
hiyouga
previously approved these changes
Apr 28, 2025
ZihengJiang
reviewed
Apr 29, 2025
| "error": repr(e), | ||
| "traceback": clean_traceback(error_traceback), | ||
| } | ||
| # if "timeoutexception" in repr(e).lower(): |
There was a problem hiding this comment.
remove instead of commenting?
There was a problem hiding this comment.
OK, rebased later.
Signed-off-by: zhanluxianshen <zhanluxianshen@163.com>
86b3003 to
33ddc71
Compare
eric-haibin-lin
approved these changes
May 15, 2025
| @@ -655,7 +622,6 @@ def reliability_guard(maximum_memory_bytes=None): | |||
| os.chmod = None | |||
| os.chown = None | |||
| os.chroot = None | |||
| os.fchdir = None | |||
There was a problem hiding this comment.
why is this removed?
There was a problem hiding this comment.
Its duplicate with above define.
thibautbar
pushed a commit
to project-numina/verl
that referenced
this pull request
May 16, 2025
Signed-off-by: zhanluxianshen <zhanluxianshen@163.com>
desaxce
pushed a commit
to project-numina/verl
that referenced
this pull request
Jul 1, 2025
Signed-off-by: zhanluxianshen <zhanluxianshen@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.